Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass the generic argument version in callback on .Option() and .Argument() #405

Merged
merged 1 commit into from
Nov 7, 2020
Merged

fix: pass the generic argument version in callback on .Option() and .Argument() #405

merged 1 commit into from
Nov 7, 2020

Conversation

natemcmaster
Copy link
Owner

@natemcmaster natemcmaster commented Nov 7, 2020 •
edited
Loading

Aligns the return type on the method and the parameter accepted on the config callback.

@natemcmaster natemcmaster merged commit 7f8553f into release/4.0 Nov 7, 2020
@natemcmaster natemcmaster deleted the feature/api-cleanup branch November 7, 2020 22:17
@natemcmaster natemcmaster added this to the 4.0.0 milestone Nov 7, 2020
natemcmaster added a commit that referenced this pull request Jan 10, 2021
@natemcmaster
fix: pass the generic argument version in callback on .Option() and .…
30e763d 
…Argument() (#405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@natemcmaster